laily/.pouch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(ack): make OMP yolo config-driven via approvalMode

Browse Source
This commit is contained in:
laily
2026-08-23 22:28:58 +08:00
parent b7b6d814b2
commit e0fffd6845
8 changed files with 94 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_ack_omp_worker.py
+44 -10
View File
@@ -15,8 +15,8 @@ import launch_worker # noqa: E402
import worker_profiles # noqa: E402
def omp_profile(*, role: str = "developer", permission: str = "workspace-write") -> dict:
return {
def omp_profile(*, role: str = "developer", permission: str = "workspace-write", approval: str | None = None) -> dict:
profile = {
"role": role,
"cli": "omp",
"tier": "standard",
@@ -24,9 +24,12 @@ def omp_profile(*, role: str = "developer", permission: str = "workspace-write")
"reasoningEffort": "low",
"permissionMode": permission,
}
if approval is not None:
profile["approvalMode"] = approval
return profile
def omp_orchestration() -> dict:
def omp_orchestration(**profile_kwargs: object) -> dict:
return {
"profileVersion": 1,
"mode": "orca",
@@ -38,7 +41,7 @@ def omp_orchestration() -> dict:
}
},
"profiles": {
"omp-dev-standard": omp_profile(),
"omp-dev-standard": omp_profile(**profile_kwargs),
"omp-test-standard": omp_profile(role="test"),
},
"defaults": {
@@ -70,8 +73,8 @@ class OmpProfileValidationTests(unittest.TestCase):
self.assertTrue(any("Test cannot define a strong allowlist" in error for error in errors))
class OmpArgvTests(unittest.TestCase):
def test_workspace_write_uses_write_approval_and_no_session(self) -> None:
class OmpApprovalModeTests(unittest.TestCase):
def test_default_workspace_write_uses_yolo(self) -> None:
argv = worker_profiles.render_worker_argv(
omp_profile(), "/usr/local/bin/omp", "/repo/demo"
)
@@ -91,16 +94,47 @@ class OmpArgvTests(unittest.TestCase):
],
)
self.assertNotIn("--auto-approve", argv)
self.assertIn("yolo", argv)
self.assertNotIn("--plan-yolo", argv)
def test_read_only_uses_always_ask_approval(self) -> None:
def test_explicit_write_turns_approval_off(self) -> None:
argv = worker_profiles.render_worker_argv(
omp_profile(approval="write"), "/usr/local/bin/omp", "/repo/demo"
)
self.assertEqual(argv[argv.index("--approval-mode") + 1], "write")
def test_explicit_always_ask_on_workspace_write(self) -> None:
argv = worker_profiles.render_worker_argv(
omp_profile(approval="always-ask"), "/usr/local/bin/omp", "/repo/demo"
)
self.assertEqual(argv[argv.index("--approval-mode") + 1], "always-ask")
def test_read_only_defaults_to_always_ask(self) -> None:
argv = worker_profiles.render_worker_argv(
omp_profile(permission="read-only"), "/usr/local/bin/omp", "/repo/demo"
)
self.assertIn("--approval-mode", argv)
self.assertEqual(argv[argv.index("--approval-mode") + 1], "always-ask")
self.assertEqual(argv[-2:], ["/repo/demo", "--no-session"])
def test_read_only_rejects_explicit_yolo(self) -> None:
routing = omp_orchestration(permission="read-only", approval="yolo")
errors = worker_profiles.validate_orchestration(routing)
self.assertTrue(any("read-only requires always-ask" in error for error in errors))
def test_approval_mode_is_only_valid_for_omp(self) -> None:
routing = omp_orchestration()
codex = routing["profiles"]["omp-dev-standard"].copy()
codex["cli"] = "codex"
codex["approvalMode"] = "yolo"
routing["profiles"]["codex-dev-standard"] = codex
routing["modelAllowlist"]["codex"] = {
"developer": {"standard": ["opencode-go/gpt-5.6-luna"]}
}
errors = worker_profiles.validate_orchestration(routing)
self.assertTrue(any("only valid for cli=omp" in error for error in errors))
def test_invalid_approval_value_is_rejected(self) -> None:
routing = omp_orchestration(approval="always-prompt")
errors = worker_profiles.validate_orchestration(routing)
self.assertTrue(any("must be yolo/write/always-ask" in error for error in errors))
def test_omp_executable_identity_matches_only_omp(self) -> None:
self.assertTrue(worker_profiles.executable_basename_matches_cli("/bin/omp", "omp"))