feat(ship): clarify delivery stop semantics
This commit is contained in:
@@ -51,7 +51,7 @@
|
||||
3. 按 JSON 行动:
|
||||
- `status: done`:写完成报告,结束。
|
||||
- `status: blocked` / `ask_user`:告诉用户缺口或问题,等回复。生产部署(`stopAt:
|
||||
released` 且下一步是 `deploy`)必须再问一次,除非当前这句话已经授权。
|
||||
deployed` 且下一步是 `deploy`)必须再问一次,除非当前这句话已经授权。
|
||||
- `actor: manager`:补账本或问用户,再跑 `next_step.py`。
|
||||
- `actor: worker`:开新 agent,等待,把结果写入 `manager.lastStep` /
|
||||
`manager.lastResult` / `manager.lastSummary`,按 `targetState` / `taskId` 更新账本,立刻
|
||||
|
||||
@@ -90,6 +90,20 @@ evidence:
|
||||
`delivery.state` 使用 delivery-loop 内部里程碑:`change_ready`、`verified`、
|
||||
`pr_opened`、`merged`、`regression_passed`、`artifact_built`、`published`、`deployed`。
|
||||
|
||||
用户可见的 canonical `stopAt` 与内部里程碑映射如下:
|
||||
|
||||
| stopAt | 停止含义 | 内部里程碑 |
|
||||
| --- | --- | --- |
|
||||
| `develop_verified` | 开发验证完成:单元测试、新增功能集成测试和静态检查通过;不等于完整回归 | `verified` |
|
||||
| `review_ready` | PR/MR 已创建,等待审核 | `pr_opened` |
|
||||
| `release_ready` | PR 已合并且完整回归通过;尚未表示发布或部署 | `regression_passed` |
|
||||
| `released` | 产物已构建并发布 | `published` |
|
||||
| `deployed` | 目标环境实际部署完成并通过健康检查 | `deployed` |
|
||||
|
||||
为兼容旧记录,`verified` 是 `develop_verified` 的别名,`validation_ready` 是
|
||||
`release_ready` 的别名;新记录应使用 canonical 名称。`delivery.state` 内部里程碑
|
||||
名称保持不变。
|
||||
|
||||
`source.kind`:`user` | `hunt` | `ack` | `pr` | `feishu`。修 ACK 缺陷时
|
||||
`source.kind: ack` 且 `ref` 为缺陷任务 id。
|
||||
|
||||
|
||||
@@ -21,6 +21,10 @@ scripts/append_evidence.py 追加后跑 scripts/validate_ship.py。
|
||||
验收:见 spec.md 与 tasks.yaml 里该任务的 expected / verification。
|
||||
授权:<本步允许的 git/PR/部署动作;未写的不要做>
|
||||
|
||||
测试边界:`verify` / `verify_task` 只负责开发阶段验证,执行任务相关的单元测试、
|
||||
新增功能集成测试和静态检查,不执行合并后的完整 tester 回归;`regress` 只在合并后
|
||||
负责完整回归,必须覆盖发现的每个 tester catalog 根和项目声明的原生测试套件。
|
||||
|
||||
若步骤是 `verify_task` 或 `regress` 且 skill 是 `tester`:先执行
|
||||
`python3 <tester-skill>/scripts/catalog.py roots --root <project-root>`。`verify_task` 按
|
||||
任务范围选择相关测试根;`regress` 必须对返回的每个独立测试根分别执行 `validate`、
|
||||
|
||||
@@ -10,7 +10,13 @@ import sys
|
||||
from pathlib import Path
|
||||
from typing import Any
|
||||
|
||||
from ship_lib import ensure_stage_layout, load_yaml, record_stage_event, stage_for_step
|
||||
from ship_lib import (
|
||||
STOP_AT_STATE,
|
||||
ensure_stage_layout,
|
||||
load_yaml,
|
||||
record_stage_event,
|
||||
stage_for_step,
|
||||
)
|
||||
|
||||
SPEC_PLACEHOLDERS = (
|
||||
"<用户可见的目标",
|
||||
@@ -26,12 +32,6 @@ TASK_PLACEHOLDERS = (
|
||||
FAULT_PLACEHOLDER = "<没有故障时删除"
|
||||
DONE_TASK = frozenset({"verified", "merged", "done"})
|
||||
READY_DEP = frozenset({"verified", "merged", "done"})
|
||||
STOP_AT_STATE = {
|
||||
"verified": "verified",
|
||||
"review_ready": "pr_opened",
|
||||
"validation_ready": "deployed",
|
||||
"released": "deployed",
|
||||
}
|
||||
DELIVERY_STEPS: tuple[tuple[str, str, str], ...] = (
|
||||
("verified", "verify", "tester"),
|
||||
("pr_opened", "open_pr", "delivery-loop"),
|
||||
@@ -173,6 +173,11 @@ def _next_delivery(
|
||||
nxt = DELIVERY_STEPS[start]
|
||||
state, step, skill = nxt
|
||||
summary = f"派 worker 把 delivery.state 推进到 {state},加载 {skill}"
|
||||
if step == "verify":
|
||||
summary = (
|
||||
"派 tester worker 做开发阶段验证:执行单元测试、新增功能集成测试和静态检查;"
|
||||
"不执行合并后的完整 tester 回归"
|
||||
)
|
||||
if step == "regress":
|
||||
summary = (
|
||||
"派 tester worker 做合并后的完整回归:先发现父仓库和子项目的所有 tester "
|
||||
@@ -323,7 +328,10 @@ def _decide_short(
|
||||
actor="manager",
|
||||
step="ask_user",
|
||||
status="ask_user",
|
||||
summary="stopAt 未配置,主会话向用户确认 verified / review_ready / validation_ready / released",
|
||||
summary=(
|
||||
"stopAt 未配置,主会话向用户确认 develop_verified / review_ready / "
|
||||
"release_ready / released / deployed"
|
||||
),
|
||||
)
|
||||
if state == "change_ready" and _needs_hunt(spec_md) and not _has_change_commit(current):
|
||||
last = _manager(current).get("lastStep")
|
||||
|
||||
@@ -48,6 +48,18 @@ DELIVERY_STATE = frozenset(
|
||||
"deployed",
|
||||
}
|
||||
)
|
||||
# User-facing stop points. The two legacy names remain accepted so existing
|
||||
# ship records continue to resolve to the new phase meanings.
|
||||
STOP_AT_STATE = {
|
||||
"develop_verified": "verified",
|
||||
"review_ready": "pr_opened",
|
||||
"release_ready": "regression_passed",
|
||||
"released": "published",
|
||||
"deployed": "deployed",
|
||||
"verified": "verified", # legacy alias for develop_verified
|
||||
"validation_ready": "regression_passed", # legacy alias for release_ready
|
||||
}
|
||||
STOP_AT = frozenset(STOP_AT_STATE)
|
||||
SOURCE_KIND = frozenset({"user", "hunt", "ack", "pr", "feishu"})
|
||||
COMMIT_ROLE = frozenset({"baseline", "merged", "head"})
|
||||
|
||||
|
||||
@@ -13,6 +13,7 @@ from ship_lib import (
|
||||
DELIVERY_STATE,
|
||||
KIND,
|
||||
SHIP_STATUS,
|
||||
STOP_AT,
|
||||
SOURCE_KIND,
|
||||
TASK_STATUS,
|
||||
check_ship_id,
|
||||
@@ -77,6 +78,17 @@ def validate_ship_dir(ship_dir: Path) -> list[str]:
|
||||
if not isinstance(data.get("title"), str) or not str(data.get("title")).strip():
|
||||
_issue(issues, "title 不能为空")
|
||||
|
||||
for path, value in (
|
||||
("stopAt", data.get("stopAt")),
|
||||
("delivery.stopAt", (data.get("delivery") or {}).get("stopAt")
|
||||
if isinstance(data.get("delivery"), dict) else None),
|
||||
):
|
||||
if value not in (None, "") and value not in STOP_AT:
|
||||
_issue(
|
||||
issues,
|
||||
f"{path} 无效: {value!r}({', '.join(sorted(STOP_AT))})",
|
||||
)
|
||||
|
||||
source = data.get("source")
|
||||
if source is not None:
|
||||
src = _mapping(source, "source", issues)
|
||||
|
||||
Reference in New Issue
Block a user